fix: split typst list items into separate sentences#206
Open
saschabuehrle wants to merge 1 commit into
Open
Conversation
|
Thank you very much for this fix |
Owner
|
Hi @saschabuehrle, thanks for your contribution! Could you add one or more tests in https://github.com/jeertmans/languagetool-rust/blob/main/tests/sample_files/example.typ and sync the snapshot files to assert that the list items are checked as expected? Running the tests will normally re-generate those snapshots files (see https://docs.rs/insta/latest/insta/). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205
Typst list and enum items were emitted back-to-back in the parsed text, so LanguageTool treated the next item as a continuation of the previous sentence.
This inserts a newline annotation after each
ListItem/EnumItemso every list entry starts as its own sentence.Greetings, saschabuehrle